Greg Sheremeta has posted comments on this change. Change subject: engine: refactor: add Model attribute for help tagging (WIP) ......................................................................
Patch Set 8: Verified+1 Ok, hopefully the last iteration of this. WIP. Vojtech and I brainstormed and we (he!) came up with the idea of moving the Strings into a CommonHelpTags interface for cleanliness and ease of parsing. For now, CommonHelpTags is a real class, but we'll change it to a GWT generated class. That part is not important / trivial. Please review the essence of the change -- the setHelpTag calls and doctag.py. Thanks. -- To view, visit http://gerrit.ovirt.org/21052 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia4074fcc2ecfcbdd2ea6c0855d92f2aa4bd26a5b Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
