Eli Mesika has posted comments on this change. Change subject: packaging: setup: database: set vdc_options correctly ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23872/1/packaging/setup/ovirt_engine_setup/database.py File packaging/setup/ovirt_engine_setup/database.py: Line 297: name=name, Line 298: version=version, Line 299: value=value, Line 300: ), Line 301: ) can be simplified 1) first select is not needed 2) switch update and insert block order 3) in update concatenate " and exists select ....." 4) in insert concatenate " and not exists select ....." Line 302: Line 303: Line 304: @util.export Line 305: class OvirtUtils(base.Base): -- To view, visit http://gerrit.ovirt.org/23872 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibe020ef3b557a5af67ee2f40e7e72bd9fe920b47 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
