Lior Vernia has uploaded a new change for review. Change subject: webadmin: Disable port mirroring for external networks ......................................................................
webadmin: Disable port mirroring for external networks Operation was blocked by backend, but not mirrored (pun intended) in the GUI. Change-Id: Idafb770e2a96ed8a85e6ef797a7e1a03998e46af Bug-Url: https://bugzilla.redhat.com/1058778 Signed-off-by: Lior Vernia <lver...@redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java 2 files changed, 21 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/74/23874/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java index 08d81c7..86caed4 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/VnicProfileModel.java @@ -32,7 +32,10 @@ import org.ovirt.engine.ui.uicommonweb.validation.IValidation; import org.ovirt.engine.ui.uicommonweb.validation.NotEmptyValidation; import org.ovirt.engine.ui.uicompat.ConstantsManager; +import org.ovirt.engine.ui.uicompat.Event; +import org.ovirt.engine.ui.uicompat.EventArgs; import org.ovirt.engine.ui.uicompat.FrontendActionAsyncResult; +import org.ovirt.engine.ui.uicompat.IEventListener; import org.ovirt.engine.ui.uicompat.IFrontendActionAsyncCallback; public abstract class VnicProfileModel extends Model { @@ -137,6 +140,21 @@ setPublicUse(publicUse); setDescription(new EntityModel()); + getNetwork().getSelectedItemChangedEvent().addListener(new IEventListener() { + @Override + public void eventRaised(Event ev, Object sender, EventArgs args) { + Network network = (Network) getNetwork().getSelectedItem(); + boolean portMirroringAllowed = (network == null || !network.isExternal()); + if (!portMirroringAllowed) { + getPortMirroring().setEntity(false); + getPortMirroring().setChangeProhibitionReason(ConstantsManager.getInstance() + .getConstants() + .portMirroringNotSupportedExternalNetworks()); + } + getPortMirroring().setIsChangable(portMirroringAllowed); + } + }); + initCustomPropertySheet(dcCompatibilityVersion); initNetworkQoSList(dcId); initCommands(); diff --git a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java index 66e6e58..362d681 100644 --- a/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java +++ b/frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/UIConstants.java @@ -1922,6 +1922,9 @@ @DefaultStringValue("'CPU Pinning topology' is only available for cluster compatible with ver 3.1 or higher") String cpuPinningUnavailableLocalStorage(); + @DefaultStringValue("'Port Mirroring' is not supported for externally-provided networks") + String portMirroringNotSupportedExternalNetworks(); + @DefaultStringValue("Low") String vmLowPriority(); -- To view, visit http://gerrit.ovirt.org/23874 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idafb770e2a96ed8a85e6ef797a7e1a03998e46af Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Lior Vernia <lver...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
