Maor Lipchuk has posted comments on this change. Change subject: core: validate disks existence on create snapshot ......................................................................
Patch Set 3: Code-Review+1 (1 comment) see minor comment regarding the message http://gerrit.ovirt.org/#/c/23706/3/frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java File frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java: Line 2537: Line 2538: @DefaultStringValue("Cannot ${action} ${type}. The specified disk does not exist.") Line 2539: String ACTION_TYPE_FAILED_DISK_NOT_EXIST(); Line 2540: Line 2541: @DefaultStringValue("Cannot ${action} ${type}. The following disk(s) does not exist: ${diskIds}.") I think that you should indicate in the message "disk(s) ids" since you are printing ids and not aliases Line 2542: String ACTION_TYPE_FAILED_DISKS_NOT_EXIST(); Line 2543: Line 2544: @DefaultStringValue("Cannot ${action} ${type}. No disks have been specified.") Line 2545: String ACTION_TYPE_FAILED_NO_DISKS_SPECIFIED(); -- To view, visit http://gerrit.ovirt.org/23706 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4d75ad139d048f83b08d9289e43d909b29f89695 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
