Martin Peřina has uploaded a new change for review. Change subject: tools: Removes inclusion of config file in engine-manage-domains.sh ......................................................................
tools: Removes inclusion of config file in engine-manage-domains.sh Removes unneeded inclusion of engine-manage-domains.conf in engine-manage-domains.sh. The variables contained in this file are needed later in java code, but not in engine-manage-domains.sh. Change-Id: Ia26468cbcc64c44adb9805c258f1625c574b4ab5 Bug-Url: https://bugzilla.redhat.com/904029 Signed-off-by: Martin Perina <mper...@redhat.com> --- M packaging/bin/engine-manage-domains.sh 1 file changed, 0 insertions(+), 16 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/39/23839/1 diff --git a/packaging/bin/engine-manage-domains.sh b/packaging/bin/engine-manage-domains.sh index b35e32f..0b6fca9 100755 --- a/packaging/bin/engine-manage-domains.sh +++ b/packaging/bin/engine-manage-domains.sh @@ -47,12 +47,6 @@ return 0 } -# TODO: -# why do we need CONF_FILE here? -# we do not use any vairable -CONF_DIR="${ENGINE_ETC}/engine-manage-domains" -CONF_FILE="${CONF_DIR}/engine-manage-domains.conf" - parseArgs() { if [ "$#" -eq 0 ] ; then usage @@ -63,13 +57,6 @@ local v="${x#*=}" shift case "${x}" in - -c) - CONF_FILE="$1" - shift - ;; - -configFile=*) - CONF_FILE="${v}" - ;; -h|-help|--help) usage exit 0 @@ -79,9 +66,6 @@ } # do this in function so we do not lose $@ parseArgs "$@" - -[ -s "${CONF_FILE}" ] || die "Configuration file '${CONF_FILE}' is either empty or does not exist" -. "${CONF_FILE}" # TODO: # what is the benefit of creating this here -- To view, visit http://gerrit.ovirt.org/23839 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ia26468cbcc64c44adb9805c258f1625c574b4ab5 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Martin Peřina <mper...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
