Eli Mesika has posted comments on this change. Change subject: core: SQL exception is thrown when assigning a permissions ......................................................................
Patch Set 1: Code-Review+2 (1 comment) http://gerrit.ovirt.org/#/c/23833/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddPermissionCommand.java: Line 106: getAdGroupDAO().save(group); Line 107: } else { Line 108: group = groupFromDb; Line 109: } Line 110: } We should think of re-factoring DbUser DbGroup and its DAOs such that they implement a common interface and we can encapsulate all the code in this 2 blocks in a simple method call. Leaving that for future .... Line 111: Line 112: // The identifier of the owner of the permission can come from the parameters directly or from the user/group Line 113: // objects: Line 114: Guid ownerId = parameters.getPermission().getad_element_id(); -- To view, visit http://gerrit.ovirt.org/23833 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie518061d081c09a25fe5582899a6105df629ab06 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
