Juan Hernandez has posted comments on this change.

Change subject: 2. core: Adding support for returning password URL change to 
client
......................................................................


Patch Set 3:

(2 comments)

http://gerrit.ovirt.org/#/c/23620/3/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/authentication/AuthenticationResult.java
File 
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/authentication/AuthenticationResult.java:

Line 13:      */
Line 14:     public abstract boolean isSuccessful();
Line 15: 
Line 16:     /**
Line 17:      * Resolves the detailed information into VdcBll messages
I have to insist on removing all references to VdcBll.
Line 18:      * @return
Line 19:      */
Line 20:     public abstract List<String> resolveMessage();


http://gerrit.ovirt.org/#/c/23620/3/backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
File 
backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties:

Line 915: CANNOT_DISABLE_VIRTIO_SCSI_PLUGGED_DISKS=Cannot disable VirtIO-SCSI 
when disks with a VirtIO-SCSI interface are plugged into the VM.
Line 916: 
Line 917: #Suspected (not in use?)
Line 918: USER_PASSWORD_EXPIRED=Cannot Login. User Password has expired, Please 
change your password.
Line 919: USER_PASSWORD_EXPIRED_CHANGE_URL_PROVIDED=Cannot Login. User Password 
has expired. Use the following URL to change the password: ${URL} 
Remember to fix this trailing whitespace.
Line 920: USER_CANNOT_LOGIN_DOMAIN_NOT_SUPPORTED=Cannot Login. The Domain 
provided is not configured, please contact your system administrator.
Line 921: VM_POOL_CANNOT_DECREASE_VMS_FROM_POOL=Cannot decrease VMs from 
VM-Pool.
Line 922: 
Line 923: # bad names


-- 
To view, visit http://gerrit.ovirt.org/23620
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0825b1624696e687d76b867f4844f7016819cf2c
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: ovirt-engine-3.4
Gerrit-Owner: Yair Zaslavsky <yzasl...@redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com>
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to