Alon Bar-Lev has posted comments on this change. Change subject: etl: fixed minimal version check ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/22831/3/tos_project/process/MinimalVersionCheck_3.4.item File tos_project/process/MinimalVersionCheck_3.4.item: Line 296: <elementParameter field="CHECK" name="ACTIVATE" value="true"/> Line 297: <elementParameter field="TEXT" name="UNIQUE_NAME" value="row2"/> Line 298: </connection> Line 299: <connection connectorName="RUN_IF" label="If" lineStyle="6" metaname="tJDBCInput_2" offsetLabelX="0" offsetLabelY="0" source="tJDBCInput_2" target="tDie_2"> Line 300: <elementParameter field="MEMO_JAVA" name="CONDITION" value="!context.ovirtEngineHistoryMinimalETL.substring(0, context.ovirtEngineHistoryMinimalETL.indexOf(".", context.ovirtEngineHistoryMinimalETL.indexOf(".")+1)).equals(context.etlVersion.substring(0, context.etlVersion.indexOf(".", context.etlVersion.indexOf(".")+1))) 
||
(
context.ovirtEngineHistoryMinimalETL.substring(0, context.ovirtEngineHistoryMinimalETL.indexOf(".", context.ovirtEngineHistoryMinimalETL.indexOf(".")+1)).equals(context.etlVersion.substring(0, context.etlVersion.indexOf(".", context.etlVersion.indexOf(".")+1)))
&&
Integer.parseInt(context.ovirtEngineHistoryMinimalETL.substring(context.ovirtEngineHistoryMinimalETL.indexOf(".", context.ovirtEngineHistoryMinimalETL.indexOf(".")+1)+1))
> 
Integer.parseInt(context.etlVersion.substring(context.etlVersion.indexO! f(".", context.etlVersion.indexOf(".")+1)+1))
)"/> this is way more complex than should be... not sure if you have any limitations... if I understand correctly it should be something like: ver1_array = split(ver1, '.') ver2_array = split(ver2, '.') ok = ver1_array[0] == ver2_array[0] && ver1_array[1] == ver2_array[1] && int(ver1_array[3]) <= int(ver1_array[3]) Line 301: <elementParameter field="CHECK" name="ACTIVATE" value="true"/> Line 302: <elementParameter field="TEXT" name="UNIQUE_NAME" value="If3"/> Line 303: </connection> Line 304: <subjob> -- To view, visit http://gerrit.ovirt.org/22831 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2a5e86d87d0f59abfad7c82b40c5695545b86e1d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Shirly Radco <sra...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
