Arik Hadas has posted comments on this change. Change subject: core: mark fields that vdsm cannot change with annotation ......................................................................
Patch Set 17: (2 comments) http://gerrit.ovirt.org/#/c/22644/17/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java: Line 9: Line 10: public class VmDynamic implements BusinessEntityWithStatus<Guid, VMStatus>, Comparable<VmDynamic> { Line 11: private static final long serialVersionUID = 7789482445091432555L; Line 12: Line 13: private Guid id; > what about at the beginning I've made this patch such that the previous list of ignore field will remain the same and only when I tested my change I discovered that lastStopTime should be marked with the annotation as well so I added it to lastStopTime in a different patch. you're right about the fields above, I'll change it in the patch where I add the annotation to lastStopTime to keep this one as one that doesn't change business logic Line 14: private VMStatus status; Line 15: private String vmIp; Line 16: private String vmFQDN; Line 17: @UnchangeableByVdsm http://gerrit.ovirt.org/#/c/22644/17/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java: Line 125: private static final int TO_MEGA_BYTES = 1024; Line 126: private static final String HOSTED_ENGINE_VM_NAME = "HostedEngine"; Line 127: private static final String EXTERNAL_VM_NAME_FORMAT = "external-%1$s"; Line 128: Line 129: /** names of fields in {@link VmDynamic} that cannot be changed by VDSM */ > maybe change "cannot be" to "are not" Done Line 130: private static final List<String> UNCHANGEABLE_FIELDS_BY_VDSM; Line 131: Line 132: static { Line 133: List<String> tmpList = new ArrayList<String>(); -- To view, visit http://gerrit.ovirt.org/22644 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8c1981a7adaa6b4ff3ba4012fbe7318f6488e2ab Gerrit-PatchSet: 17 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
