Daniel Erez has uploaded a new change for review. Change subject: core: fix stateless flow in RestoreAllSnapshots ......................................................................
core: fix stateless flow in RestoreAllSnapshots RestoreAllSnapshotsCommand -> restoreSnapshotAndRemoveObsoleteSnapshots: * Global member 'imagesToRestore' should be assigned in STATELESS case as well. * Decoupled PREVIEW and STATELESS cases for readability and easier maintenance. Change-Id: I9aeb6ac37b511e0cd39b290f9571d0a73c7a5717 Bug-Uril: https://bugzilla.redhat.com/1057221 Signed-off-by: Daniel Erez <de...@redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/89/23789/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java index 1083ae1..7a7341b 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java @@ -245,8 +245,11 @@ imagesToRestore = imagesFromPreviewSnapshot; updateSnapshotIdForSkipRestoreImages( ImagesHandler.imagesSubtract(imagesFromActiveSnapshot, imagesToRestore), targetSnapshot.getId()); + restoreConfiguration(targetSnapshot); + break; case STATELESS: + imagesToRestore = getParameters().getImages(); restoreConfiguration(targetSnapshot); break; -- To view, visit http://gerrit.ovirt.org/23789 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9aeb6ac37b511e0cd39b290f9571d0a73c7a5717 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <de...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
