Federico Simoncelli has posted comments on this change. Change subject: core: prevent maintenance when domain is still in use ......................................................................
Patch Set 11: (1 comment) http://gerrit.ovirt.org/#/c/22045/11/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java: Line 309: } Line 310: List<StorageDomain> domainsInDb = DbFacade.getInstance().getStorageDomainDao() Line 311: .getAllForStoragePool(_storagePoolId); Line 312: Line 313: Set<Guid> activeVdsInPool = null; Rename to vdsConnectedToPool Line 314: Line 315: for (final StorageDomain domainInDb : domainsInDb) { Line 316: if (domainInDb.getStorageDomainType() != StorageDomainType.Master Line 317: && domainInDb.getStatus() != StorageDomainStatus.Locked -- To view, visit http://gerrit.ovirt.org/22045 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I55cd5aa6a6dc32f374a4bb21b159d3cb30da65f5 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
