Liron Ar has posted comments on this change. Change subject: core: Use shorter scope for try catch block ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23756/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java: Line 65: log.errorFormat("Failed creating snapshot from image id -'{0}'", getImage().getImageId()); Line 66: throw new VdcBLLException(VdcBllErrors.VolumeCreationError); Line 67: } Line 68: Line 69: if (vdsReturnValue.getSucceeded()) { > If an exception occurs we throw it at line 76, so if we already got here, t ignore. Line 70: getReturnValue().getInternalVdsmTaskIdList().add( Line 71: createTask(taskId, Line 72: vdsReturnValue.getCreationInfo(), Line 73: VdcActionType.AddVmFromTemplate, -- To view, visit http://gerrit.ovirt.org/23756 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icbdfa7acaac633a1e2010db5fd9fc9afe4fab219 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
