[Engine-patches] Change in ovirt-engine[master]: core: Seep the exception from VDSM to the user

[mlipchuk]

Maor Lipchuk has uploaded a new change for review.

Change subject: core: Seep the exception from VDSM to the user
......................................................................

core: Seep the exception from VDSM to the user

Seep the exception got from VDSM instead replacing it every time.

Change-Id: Ief319b187950fe188b54aad240e59cda807c0ef9
Signed-off-by: Maor Lipchuk <mlipc...@redhat.com>
---
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
M 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java
2 files changed, 2 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/57/23757/1

diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
index 6ba8b1b..856c604 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromTemplateCommand.java
@@ -86,7 +86,7 @@
 
                 // if couldn't create snapshot then stop the transaction and 
the command
                 if (!result.getSucceeded()) {
-                    throw new 
VdcBLLException(VdcBllErrors.VolumeCreationError);
+                    throw new VdcBLLException(result.getFault().getError());
                 } else {
                     getTaskIdList().addAll(result.getInternalVdsmTaskIdList());
                     DiskImage newImage = (DiskImage) 
result.getActionReturnValue();
diff --git 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java
 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java
index e35db7b..fd55aca 100644
--- 
a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java
+++ 
b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateCloneOfTemplateCommand.java
@@ -10,7 +10,6 @@
 import org.ovirt.engine.core.common.businessentities.CopyVolumeType;
 import org.ovirt.engine.core.common.businessentities.DiskImage;
 import org.ovirt.engine.core.common.errors.VdcBLLException;
-import org.ovirt.engine.core.common.errors.VdcBllErrors;
 import org.ovirt.engine.core.common.vdscommands.CopyImageVDSCommandParameters;
 import org.ovirt.engine.core.common.vdscommands.VDSCommandType;
 import org.ovirt.engine.core.common.vdscommands.VDSReturnValue;
@@ -63,7 +62,7 @@
 
         } catch (VdcBLLException e) {
             log.errorFormat("Failed creating snapshot from image id -'{0}'", 
getImage().getImageId());
-            throw new VdcBLLException(VdcBllErrors.VolumeCreationError);
+            throw e;
         }
 
         if (vdsReturnValue.getSucceeded()) {


-- 
To view, visit http://gerrit.ovirt.org/23757
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief319b187950fe188b54aad240e59cda807c0ef9
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches