Arik Hadas has posted comments on this change. Change subject: core: managed removal of memory volumes in negative flows ......................................................................
Patch Set 2: Liron, thanks for your comment. "deleteImage should be treated by the engine as sync operation, after the sync part of the vdsm verb is completed the image no longer exists and we poll the task just to clear it" That's exactly what I'm doing. The polling is done as part of the RemoveMemoryVolumesCommand as a separate flow that doesn't affect the rest of the ImportVmCommand/CreateAllSnapshotsFromVmCommand, just for the polling which was missing before. "You should use the RemoveImage command (possibly add there a flag inidcating to not remove anything from the db) and after succesfull execution perform your needed operations" I think it will just make the RemoveImage command to be more complicated and I don't see why it is good. We plan to make the memory volumes much more similar to disk images and then it might be the right thing to do. currently I prefer to do it as it was done for hibernation volumes before. "You can poll the tasks by calling startPollingAsyncTasks(..) so they'll be polled and cleared by the engine. You can take an example from CopyImageGroupCommand.revertTasks - just set the parent parameters to the remove image parameters and the parent command to remove image." yeah I know, it was that way before for hibernation volumes . To me it looks like a hack, I would like to use the infrastructure to do the polling whenever I can, as I do in this patch. -- To view, visit http://gerrit.ovirt.org/23222 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib4b270ec0e1ab41cae34459dde9f9cf47b1b5bdf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
