Maor Lipchuk has posted comments on this change. Change subject: core: Execute clear tasks with new thread. ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23724/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java: Line 370: AsyncTasks task = getAsyncTaskDao().get(asyncTaskId); Line 371: if (task != null && Guid.isNullOrEmpty(task.getVdsmTaskId())) { Line 372: AsyncTaskManager.removeTaskFromDbByTaskId(task.getTaskId()); Line 373: } Line 374: > so if here exception is raised, don't you want to log it somewhere? Well I didn't meant to change this code, only fix the transaction issue, but you got a point there. so I checked the code: The thing is, that in removeTaskFromDbByTaskId we already log an error if it occurs. So I'm not sure if it is necessary to add a log here also, unless you think otherwise? Line 375: } Line 376: return null; Line 377: } Line 378: }); -- To view, visit http://gerrit.ovirt.org/23724 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3434c2dbd605e741b2cfbbede8c4a120f21ca9fe Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Ravi Nori <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> Gerrit-Reviewer: Yaniv Bronhaim <[email protected]> Gerrit-Reviewer: mooli tayer <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
