Liron Ar has posted comments on this change. Change subject: core: add StorageDomainOvfInfo entity/db ......................................................................
Patch Set 6: (3 comments) http://gerrit.ovirt.org/#/c/23461/6/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Disk.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/Disk.java: Line 23: */ Line 24: private VmEntityType vmEntityType; Line 25: private int numberOfVms; Line 26: private ArrayList<String> vmNames; Line 27: private boolean ovfStore; > Only disk image can be an OVF storage if I'm not mistaken, why put it in Di because i plan to add the option to also use lun disks as ovf stores. Line 28: Line 29: /** Line 30: * Plugged and readOnly are of type Boolean (as opposed to boolean) since they are optional. Line 31: * In case the disk is not in a vm context, null will ensure they are invisible. http://gerrit.ovirt.org/#/c/23461/6/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java: Line 636: return getDao(StorageDomainDAO.class); Line 637: } Line 638: Line 639: /** Line 640: * Returns the singleton instance of {@link StorageDomainDAO}. > s/StorageDomainDAO/StorageDomainOvfInfoDao Done Line 641: * Line 642: * @return the dao Line 643: */ Line 644: public StorageDomainOvfInfoDao getStorageDomainOvfInfoDao() { http://gerrit.ovirt.org/#/c/23461/6/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainOvfInfoDbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/StorageDomainOvfInfoDbFacadeImpl.java: Line 75: getCustomMapSqlParameterSource().addValue("storage_domain_id", guid)); Line 76: } Line 77: Line 78: @Override Line 79: public List<StorageDomainOvfInfo> getAll() { > Need to be implemented I assume i don't see a need to implement as its not used now and i don't see scenario in which it will be..if it'll be relevant we could add it - changed it to through notimplementedexception. I'll remove the generated comment. Line 80: return null; //To change body of implemented methods use File | Settings | File Templates. Line 81: } Line 82: Line 83: @Override -- To view, visit http://gerrit.ovirt.org/23461 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6cd52f5b9f14559bcec224dee868cf267cd15ebe Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
