Liron Ar has posted comments on this change. Change subject: vdsbroker: improve the domain visibility cache ......................................................................
Patch Set 7: Code-Review-1 I think that there approach in IrsBrokerCommand should be a bit different . Currently the domain failover process get a problematic report about a domain by any of the hosts, sets a timer to execute the "examination" method in X minutes. The "examination" method check the report of all the hosts on the given domain and acts accordingly. IMO that's exactly what we should use for this change, just change the behavior a bit (instead of "failing" the domain as we do today, move it to maintenance). We would still be required to change the in memory data struacture that we use, but all the rest can and should remain the same IMO to not add possible issues/regressions to those flows and another synchronization "points". -- To view, visit http://gerrit.ovirt.org/23370 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id74f12d108f75924fbff28409a89bc1caff05908 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Ayal Baron <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Federico Simoncelli <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
