Yair Zaslavsky has posted comments on this change. Change subject: tools: Adds more validations to MAIL_PORT in notifier ......................................................................
Patch Set 1: (1 comment) http://gerrit.ovirt.org/#/c/23504/1/backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java File backend/manager/tools/src/main/java/org/ovirt/engine/core/notifier/utils/NotificationProperties.java: Line 146: NotificationProperties.MAIL_SMTP_ENCRYPTION_TLS Line 147: )); Line 148: } Line 149: Line 150: boolean mailPortValid = false; > would be nicer to have this in a function Not sure how much it's critical here, you can see other validations are not in methods as well, but it's definitely worth considering for future patches. Line 151: try { Line 152: int port = new Integer(getProperty(MAIL_PORT)); Line 153: if (port > 0 && port < 65536) { Line 154: mailPortValid = true; -- To view, visit http://gerrit.ovirt.org/23504 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I770d1636dc25c0c9b0076a92dcac20ddec551acf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
