Tal Nisan has posted comments on this change. Change subject: core: AddDiskCommand - support for running as internal command ......................................................................
Patch Set 8: (1 comment) http://gerrit.ovirt.org/#/c/23463/8/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java: Line 375: parameters.setShouldRemainIllegalOnFailedExecution(getParameters().isShouldRemainIllegalOnFailedExecution()); Line 376: parameters.setStorageDomainId(getStorageDomainId()); Line 377: if (getParameters().getParentCommand() == VdcActionType.Unknown){ Line 378: parameters.setParentCommand(VdcActionType.AddDisk); Line 379: parameters.setParentParameters(getParameters()); Any reason to add it? cause it didn't exist in the original scenario when the AddDisk command was the parent Line 380: } else { Line 381: parameters.setParentCommand(getParameters().getParentCommand()); Line 382: parameters.setParentParameters(getParameters().getParentParameters()); Line 383: } -- To view, visit http://gerrit.ovirt.org/23463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8236d2f0f8139a969f2cf1ee1f706180a0d3b134 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
