Tal Nisan has posted comments on this change. Change subject: core: AddDiskCommand - add option to leave disk as illegal on failure ......................................................................
Patch Set 8: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/23462/8/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddImageFromScratchParameters.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddImageFromScratchParameters.java: Line 7: Line 8: private static final long serialVersionUID = 8249273209551108387L; Line 9: private Guid masterVmId; Line 10: private DiskImageBase diskInfo; Line 11: private boolean shouldRemainIllegalOnFailedExecution; I'd call it retainAsIllegalOnFailure, shorter and more coherent imo, just a suggestion though Line 12: Line 13: public AddImageFromScratchParameters() { Line 14: masterVmId = Guid.Empty; Line 15: } -- To view, visit http://gerrit.ovirt.org/23462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8ccf85a2ab38e96dc934be36acb5ac70a41f5e47 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
