Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: use arch limit for shmmax ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/23641/1/packaging/setup/ovirt_engine_setup/constants.py File packaging/setup/ovirt_engine_setup/constants.py: Line 72: 'default': 4294967295, Line 73: } Line 74: Line 75: @staticmethod Line 76: def get_limit(): getLimit? Line 77: arch = platform.machine() Line 78: if not arch in SHMMax.ARCH_LIMITS: Line 79: arch = 'default' Line 80: return SHMMax.ARCH_LIMITS[arch] Line 76: def get_limit(): Line 77: arch = platform.machine() Line 78: if not arch in SHMMax.ARCH_LIMITS: Line 79: arch = 'default' Line 80: return SHMMax.ARCH_LIMITS[arch] consider: return self.ARCH_LIMIT.get(arch, self.ARCH_LIMIT['default']) Line 81: Line 82: Line 83: @util.export Line 84: class FileLocations(object): Line 456: DEFAULT_SYSTEM_GROUP_KVM = 'kvm' Line 457: DEFAULT_SYSTEM_GROUP_ENGINE = 'ovirt' Line 458: DEFAULT_SYSTEM_USER_POSTGRES = 'postgres' Line 459: Line 460: DEFAULT_SYSTEM_SHMMAX = SHMMax.get_limit() oh... it is constants... so wh not just put it here? @classproperty def DEFAULT_SYSTEM_SHMMAX(self): SHMMAX = { .... } return SHMMAX.get(platform.machine(), SHMMAX['default']) Line 461: Line 462: DEFAULT_SYSTEM_MEMCHECK_MINIMUM_MB = 4096 Line 463: DEFAULT_SYSTEM_MEMCHECK_RECOMMENDED_MB = 16384 Line 464: DEFAULT_SYSTEM_MEMCHECK_THRESHOLD = 90 -- To view, visit http://gerrit.ovirt.org/23641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbc9b651d2f9e47e58c75b44bd84418990f59d60 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
