Roy Golan has posted comments on this change. Change subject: core: add template version related fields to vm and template ......................................................................
Patch Set 1: (1 comment) Martin can you check the inside comment on Cloner.java? http://gerrit.ovirt.org/#/c/23606/1/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Cloner.java: Line 212: vm.setCreatedByUserId(instance.getCreatedByUserId()); Line 213: vm.setClusterArch(instance.getClusterArch()); Line 214: vm.setOriginalTemplateGuid(instance.getOriginalTemplateGuid()); Line 215: vm.setOriginalTemplateName(instance.getOriginalTemplateName()); Line 216: vm.setMigrationDowntime(instance.getMigrationDowntime()); why is this migrationDowntime here by your patch? Martin is this a merge issue? Line 217: vm.setUseLatestVersion(instance.isUseLatestVersion()); Line 218: Line 219: return vm; Line 220: } -- To view, visit http://gerrit.ovirt.org/23606 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I08f13eee5609525880a92fc81c9fd3cb1d2ba62d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.4 Gerrit-Owner: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Martin Betak <mbe...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
