Allon Mureinik has posted comments on this change. Change subject: core: replace explicit field names with constants ......................................................................
Patch Set 3: Code-Review+1 (1 comment) +1 on the code, minor suggestion on the commit message. I'm leaving the +2 to Roy/Omer http://gerrit.ovirt.org/#/c/23101/3//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-01-09 17:35:20 +0200 Line 4: Commit: Arik Hadas <aha...@redhat.com> Line 5: CommitDate: 2014-01-22 15:47:13 +0200 Line 6: Line 7: core: replace explicit field names with constants perhaps "hardcoded" would be a better term? Line 8: Line 9: In VdsUpdateRunTimeInfo we used to have explicit strings for "appList" Line 10: and "status", representing the names of those fields in VmDynamic. Line 11: This patch changes that - new constants are declared in VmDynamic, -- To view, visit http://gerrit.ovirt.org/23101 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I614fecc4238cfffbf152b1b39e3c7995974188c2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
