Maor Lipchuk has posted comments on this change.

Change subject: core: Filter shareable disk when creating snapshot
......................................................................


Patch Set 7: (1 inline comment)

....................................................
File 
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
Line 67:                 if 
(getParameters().getActiveDiskList().contains(vmDisk.getId())) {
Active disks should be removed since allow_snapshot will replace it, will be in 
next patch

--
To view, visit http://gerrit.ovirt.org/3791
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I45370ae18910d9b33844822d59ef293e4239796d
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to