Maor Lipchuk has posted comments on this change. Change subject: frontend: Add active disks when creating a snapshot. ......................................................................
Patch Set 4: (1 inline comment) .................................................... File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateAllSnapshotsFromVmParameters.java Line 24: After talked with mkolesnik, there is no need to pass active list from the client, since by adding the allow_snapshot attribute, user will be able to choose whether to add the disk to the snapshot or not. In the next patch I will send, I will remove these patch from the patch set -- To view, visit http://gerrit.ovirt.org/4225 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9c0cbfdc041ca9337c752ad56edc96dd6b67df4b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michael Kublin <mkub...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
