Liron Ar has posted comments on this change. Change subject: core: add the domain detaching state ......................................................................
Patch Set 1: (3 comments) http://gerrit.ovirt.org/#/c/23556/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java: Line 1041: } Line 1042: } Line 1043: } else { Line 1044: domainStatus = isDomainReportedAsProblematic(domainData, false) ? Line 1045: DomainVisibility.Status.UNREACHABLE : DomainVisibility.Status.ACTIVE; seems this block needs to be changed (on the relevant patch) if the host shouldn't report the domain (Detaching/MovingToMaintenance) and reports it, we should just refresh the host - why would we inspect the report? add timer..etc. Line 1046: if (poolDomain.getStatus() == StorageDomainStatus.MovingToMaintenance Line 1047: || poolDomain.getStatus() == StorageDomainStatus.Maintenance) { Line 1048: vdsNeedsRefresh = true; Line 1049: } Line 1043: } else { Line 1044: domainStatus = isDomainReportedAsProblematic(domainData, false) ? Line 1045: DomainVisibility.Status.UNREACHABLE : DomainVisibility.Status.ACTIVE; Line 1046: if (poolDomain.getStatus() == StorageDomainStatus.MovingToMaintenance Line 1047: || poolDomain.getStatus() == StorageDomainStatus.Maintenance) { shouldn't be Detaching? Line 1048: vdsNeedsRefresh = true; Line 1049: } Line 1050: } Line 1051: Line 1125: Line 1126: log.infoFormat("Detaching domain {0} from pool", domain.getId(), _storagePoolId); Line 1127: StoragePoolIsoMap mapToRemove = domain.getStoragePoolIsoMapData(); Line 1128: DbFacade.getInstance().getStoragePoolIsoMapDao().remove( Line 1129: new StoragePoolIsoMapId(mapToRemove.getstorage_id(), mapToRemove.getstorage_pool_id())); when it will be cleared from DomainsVisibllity? Line 1130: } Line 1131: Line 1132: private void moveDomainToMaintenance(StorageDomain domain) { Line 1133: // This is relevant only for domains that are in the process of being moved to maintenance -- To view, visit http://gerrit.ovirt.org/23556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5732ef00a67ef1381ee0b6f29d08ab39cf63a1bf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
