Roy Golan has posted comments on this change. Change subject: core: support adding template version ......................................................................
Patch Set 21: (1 comment) http://gerrit.ovirt.org/#/c/22738/21/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java: Line 720: list.add(new QuotaSanityParameter(getQuotaId(), null)); Line 721: return list; Line 722: } Line 723: Line 724: @Override small issue. the shared lock should be taken only if we aren't createing this template as a baseversion - I suggest to ask !isBaseVersion() so we won't place a bogus entry in the LockManager because the UUID doesn' exist. Line 725: protected Map<String, Pair<String, String>> getSharedLocks() { Line 726: return Collections.singletonMap(String.valueOf(getParameters().getBaseTemplateId()), Line 727: LockMessagesMatchUtil.makeLockingPair(LockingGroup.TEMPLATE, VdcBllMessages.ACTION_TYPE_FAILED_OBJECT_LOCKED)); Line 728: } -- To view, visit http://gerrit.ovirt.org/22738 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id256ade6e3973d5ad00daa267f80e5ce42b87872 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Alissa Bonas <abo...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
