Sandro Bonazzola has posted comments on this change. Change subject: packaging: build: rewrite ......................................................................
Patch Set 3: (2 comments) http://gerrit.ovirt.org/#/c/23523/3/Makefile.am File Makefile.am: Line 5: # The ASF licenses this file to You under the Apache License, Version 2.0 Line 6: # (the "License"); you may not use this file except in compliance with Line 7: # the License. You may obtain a copy of the License at Line 8: # Line 9: # http://www.apache.org/licenses/LICENSE-2.0 According to http://www.ovirt.org/How_to_license_a_project, above should be: # Copyright (C) 2012-2014 Red Hat, Inc. # # Licensed under the Apache License, Version 2.0 (the "License"); # you may not use this file except in compliance with the License. # You may obtain a copy of the License at # # http://www.apache.org/licenses/LICENSE-2.0 Line 10: # Line 11: # Unless required by applicable law or agreed to in writing, software Line 12: # distributed under the License is distributed on an "AS IS" BASIS, Line 13: # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. http://gerrit.ovirt.org/#/c/23523/3/configure.ac File configure.ac: Line 5: dnl The ASF licenses this file to You under the Apache License, Version 2.0 Line 6: dnl (the "License"); you may not use this file except in compliance with Line 7: dnl the License. You may obtain a copy of the License at Line 8: dnl Line 9: dnl http://www.apache.org/licenses/LICENSE-2.0 same here Line 10: dnl Line 11: dnl Unless required by applicable law or agreed to in writing, software Line 12: dnl distributed under the License is distributed on an "AS IS" BASIS, Line 13: dnl WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -- To view, visit http://gerrit.ovirt.org/23523 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b8dad0614300948cdc6fcc3ad2766ddff0caff1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-release Gerrit-Branch: master Gerrit-Owner: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: David Caro <dcaro...@redhat.com> Gerrit-Reviewer: Eyal Edri <ee...@redhat.com> Gerrit-Reviewer: Kiril Nesenko <knese...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches