Moti Asayag has posted comments on this change.

Change subject: webadmin: Lift max MTU limit
......................................................................


Patch Set 1: -Code-Review

Rethinking this issue, I think we can take this one step further and to change 
the Network.mtu type from int to Integer, where null indicates no value was set 
by the user.

Later on, on SetupNetworksVDSCommand we should pass MTU only if its value isn't 
null.

The MtuValidator, its annotation ans its test can be dropped and we should use 
instead the @Min(68) annotation to state the allowed lower bound of the MTU.

To complete this, an upgrade script should be provided to modify all the '0' 
values on the network table to 'null'.

No changes are expect in the REST.

So basically at the end we'll end up with less code but with the same 
functionality which is good.

-- 
To view, visit http://gerrit.ovirt.org/23482
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I352ac3e00d657f00b6cec5dcb23475a143a9c8fd
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Lior Vernia <lver...@redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-HasComments: No
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to