Liran Zelkha has posted comments on this change. Change subject: engine: Make VDSUpdateRuntimeInfo load partial VDS object ......................................................................
Patch Set 10: (2 comments) http://gerrit.ovirt.org/#/c/21662/10/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacade.java: Line 311 Line 312 Line 313 Line 314 Line 315 > [if this is the case] when using eclipse, and saving the file, it auto adds No whitespaces in the file. I guess it's the gerrit file compare getting confused. http://gerrit.ovirt.org/#/c/21662/10/backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/PartialVdsDAODbFacadeImpl.java File backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/PartialVdsDAODbFacadeImpl.java: Line 15: vdsPartial.setStaticData(DbFacade.getInstance().getVdsStaticDao().get(vdsId)); Line 16: vdsPartial.setDynamicData(DbFacade.getInstance().getVdsDynamicDao().get(vdsId)); Line 17: Line 18: // TODO: A future patch will load this from cache Line 19: VDSGroup group = DbFacade.getInstance().getVdsGroupDao().get(vdsPartial.getVdsGroupId()); > I thought you'll assemble the host in the stored proc. Na, I want to do it in the code, and later use caching... Line 20: vdsPartial.setVdsGroupCompatibilityVersion(group.getcompatibility_version()); Line 21: vdsPartial.setVdsGroupCpuName(group.getcpu_name()); Line 22: vdsPartial.setVdsGroupDescription(group.getdescription()); Line 23: vdsPartial.setVdsGroupName(group.getName()); -- To view, visit http://gerrit.ovirt.org/21662 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7d72c21f1686c4031607d793bbbefcc3e45e98cb Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
