Martin Peřina has posted comments on this change. Change subject: 18. core: Add remote user authenticator ......................................................................
Patch Set 22: (1 comment) http://gerrit.ovirt.org/#/c/21299/22/backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/remote/RemoteUserAuthenticator.java File backend/manager/modules/authentication/src/main/java/org/ovirt/engine/core/authentication/remote/RemoteUserAuthenticator.java: Line 1: package org.ovirt.engine.core.authentication.remote; Line 2: Line 3: import static org.apache.commons.lang.StringUtils.isEmpty; Please don't use static import for this, it's called only once and in other files in project it's called directly (I mean StringUtils.isEmpty()) Line 4: Line 5: import javax.servlet.http.HttpServletRequest; Line 6: import javax.servlet.http.HttpServletResponse; Line 7: -- To view, visit http://gerrit.ovirt.org/21299 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0856ac9b9631f3b25eff4a9c93bb548727c74587 Gerrit-PatchSet: 22 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
