Vojtech Szocs has posted comments on this change. Change subject: webadmin,userportal: Improve UiCommon Editor integration ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/23246/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/binding/UiCommonEditorDriverGenerator.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/binding/UiCommonEditorDriverGenerator.java: Line 16: import com.google.gwt.editor.rebind.model.EditorData; Line 17: import com.google.gwt.editor.rebind.model.EditorModel; Line 18: import com.google.gwt.user.rebind.SourceWriter; Line 19: Line 20: public class UiCommonEditorDriverGenerator extends AbstractEditorDriverGenerator { > worth extracting the typos/formatting issues in this file to a separate pat I agree. Line 21: Line 22: private JClassType entityModelType; Line 23: private JClassType listModelType; Line 24: private TreeLogger logger; http://gerrit.ovirt.org/#/c/23246/1/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/AbstractUiCommonModelEditorDriver.java File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/editor/AbstractUiCommonModelEditorDriver.java: Line 24: */ Line 25: public abstract class AbstractUiCommonModelEditorDriver<T extends Model, E extends Editor<T>> Line 26: extends BaseEditorDriver<T, E> implements SimpleBeanEditorDriver<T, E> { Line 27: Line 28: private IEventListener propertyChangeListener; > same Agreed :-) Line 29: private EditorVisitor visitor; Line 30: Line 31: /** Line 32: * {@inheritDoc} <BR> -- To view, visit http://gerrit.ovirt.org/23246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd5a5456966b99e9d2eef8b5a0199f04793b315e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
