[Engine-patches] Change in ovirt-engine[master]: Engine: Vm Init - new Feature

[ofrenkel]

Omer Frenkel has posted comments on this change.

Change subject: Engine: Vm Init - new Feature
......................................................................


Patch Set 18:

(3 comments)

http://gerrit.ovirt.org/#/c/23020/18/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java
File 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java:

Line 69: 
Line 70:     }
Line 71: 
Line 72:     protected boolean vmInitEnabled() {
Line 73:         return new Version(version).compareTo(Version.v3_4) < 0 ? 
false : true;
if this is not in use anymore, please remove it
Line 74:     }
Line 75: 
Line 76:     public String getName() {
Line 77:         return name;


Line 552:             }
Line 553:             if (node.attributes.get("ovf:rootPassword") != null) {
Line 554:                 
vmInit.setRootPassword(node.attributes.get("ovf:rootPassword").getValue());
Line 555:             }
Line 556:             if (node.attributes.get("ovf:custromScript") != null) {
whats with the typo?
Line 557:                 
vmInit.setCustromScript(node.attributes.get("ovf:custromScript").getValue());
Line 558:             }
Line 559:         }
Line 560:     }


http://gerrit.ovirt.org/#/c/23020/18/backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
File 
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java:

Line 128:             if (vmInit.getRootPassword() != null) {
Line 129:                 _writer.WriteAttributeString(OVF_URI, "rootPassword", 
vmInit.getRootPassword());
Line 130:             }
Line 131:             if (vmInit.getCustromScript() != null) {
Line 132:                 _writer.WriteAttributeString(OVF_URI, 
"custromScript", vmInit.getCustromScript());
typo...
Line 133:             }
Line 134:             _writer.WriteEndElement();
Line 135:         }
Line 136:     }


-- 
To view, visit http://gerrit.ovirt.org/23020
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9383727c42713a0fda6d21782e2de708bfb57e47
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches