Alexander Wels has posted comments on this change. Change subject: webadmin: Double click collapse system tree ......................................................................
Patch Set 2: (1 comment) http://gerrit.ovirt.org/#/c/22657/2/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/main/TabbedSplitLayoutPanel.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/main/TabbedSplitLayoutPanel.java: Line 183: layoutCommand = null; Line 184: forceLayout(); Line 185: } Line 186: }; Line 187: Scheduler.get().scheduleDeferred(layoutCommand); > Hm, I'm wondering why we need to remember layoutCommand here - why not simp Its been a while since I wrote this, the only thing I can think of right now is that this is a minor optimization, where setWestPanelSize is called several times quickly, and that would cause several forceLayouts to be called when the scheduler gets a chance to run. Line 188: } Line 189: } Line 190: Line 191: /** -- To view, visit http://gerrit.ovirt.org/22657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ida98ac456d9dd325ba1bf5676671bf53b5c3173e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Alexander Wels <aw...@redhat.com> Gerrit-Reviewer: Einav Cohen <eco...@redhat.com> Gerrit-Reviewer: Greg Sheremeta <gsher...@redhat.com> Gerrit-Reviewer: Vojtech Szocs <vsz...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
