Yedidyah Bar David has uploaded a new change for review.
Change subject: packaging: setup: export iso domain ro to the world
......................................................................
packaging: setup: export iso domain ro to the world
Since Ia35aaf42cb46247a2a02df1c2418f4613ad6b965 we ask the user for the
ACL to use when exporting the iso domain. We kept the default to be the
same as the old behavior - export read-write to the entire network.
This change changes the default to export read-write only to the engine
host, and read-only to all.
Change-Id: I504d608896277d66b7c8adfe6e7f45ea00255fb8
Signed-off-by: Yedidyah Bar David <d...@redhat.com>
---
M packaging/setup/ovirt_engine_setup/constants.py
M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/iso_domain.py
2 files changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/50/23450/1
diff --git a/packaging/setup/ovirt_engine_setup/constants.py
b/packaging/setup/ovirt_engine_setup/constants.py
index 9b45c65..802ae63 100644
--- a/packaging/setup/ovirt_engine_setup/constants.py
+++ b/packaging/setup/ovirt_engine_setup/constants.py
@@ -622,7 +622,6 @@
FIREWALL_MANAGER_HUMAN = 'skip'
FIREWALL_MANAGER_IPTABLES = 'iptables'
FIREWALL_MANAGER_FIREWALLD = 'firewalld'
- ISO_DOMAIN_NFS_DEFAULT_ACL = '0.0.0.0/0.0.0.0(rw)'
ENGINE_DB_BACKUP_PREFIX = 'engine'
@classproperty
diff --git
a/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/iso_domain.py
b/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/iso_domain.py
index 166addf..de460eb 100644
---
a/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/iso_domain.py
+++
b/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/iso_domain.py
@@ -369,7 +369,9 @@
note=_('Local ISO domain ACL [@DEFAULT@]: '),
prompt=True,
caseSensitive=True,
- default=osetupcons.Const.ISO_DOMAIN_NFS_DEFAULT_ACL,
+ default='{fqdn}(rw) *(ro)'.format(
+ fqdn=self.environment[osetupcons.ConfigEnv.FQDN],
+ ),
)
if self.environment[
--
To view, visit http://gerrit.ovirt.org/23450
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I504d608896277d66b7c8adfe6e7f45ea00255fb8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yedidyah Bar David <d...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
