Vitor de Lima has posted comments on this change. Change subject: core, engine: Avoid migration in ppc64 ......................................................................
Patch Set 10: (3 comments) http://gerrit.ovirt.org/#/c/21522/10/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommandTest.java: Line 52: private static final Version VERSION_1_2 = new Version(1, 2); Line 53: private static final Guid STORAGE_POOL_ID = Guid.newGuid(); Line 54: private static final Guid DEFAULT_VDS_GROUP_ID = new Guid("99408929-82CF-4DC7-A532-9D998063FA95"); Line 55: Line 56: private static Map<String, String> migrationMap = new HashMap<>(); > should be final Done Line 57: Line 58: static { Line 59: migrationMap.put("undefined", "true"); Line 60: migrationMap.put("x86_64", "true"); http://gerrit.ovirt.org/#/c/21522/10/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java File backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java: Line 64: Line 65: @Mock Line 66: OsRepository osRepository; Line 67: Line 68: private static Map<String, String> migrationMap = new HashMap<>(); > should be final Done Line 69: Line 70: static { Line 71: migrationMap.put("undefined", "true"); Line 72: migrationMap.put("x86_64", "true"); http://gerrit.ovirt.org/#/c/21522/10/backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java File backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllMessages.java: Line 633: ACTION_TYPE_FAILED_VM_CANNOT_BE_PINNED_TO_CPU_WITH_UNDEFINED_HOST(ErrorType.BAD_PARAMETERS), Line 634: VM_PINNED_TO_HOST_CANNOT_RUN_ON_THE_DEFAULT_VDS(ErrorType.CONFLICT), Line 635: HOST_NAME_NOT_AVAILABLE(ErrorType.BAD_PARAMETERS), Line 636: VM_HOSTCPU_MUST_BE_PINNED_TO_HOST(ErrorType.CONFLICT), Line 637: MIGRATION_IS_NOT_SUPPORTED(ErrorType.CONFLICT), > probably should be replaced with ErrorType.NOT_SUPPORTED Done Line 638: MIGRATION_ON_ERROR_IS_NOT_SUPPORTED(ErrorType.CONFLICT), Line 639: VM_MIGRATION_IS_NOT_SUPPORTED(ErrorType.CONFLICT), Line 640: Line 641: ACTION_TYPE_FAILED_STORAGE_POOL_IS_NOT_LOCAL(ErrorType.BAD_PARAMETERS), -- To view, visit http://gerrit.ovirt.org/21522 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4808f3e91ccf37462727a28d35f9f9faae1dfd6c Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
