Sergey Gotliv has posted comments on this change. Change subject: webadmin: Allow to configure ISCSI multipathing in the dc context ......................................................................
Patch Set 11: Verified-1 (2 comments) http://gerrit.ovirt.org/#/c/22953/11/frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/pool/IscsiBondPopupWidget.ui.xml File frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/pool/IscsiBondPopupWidget.ui.xml: Line 14: border-bottom: 1px #C0C0C0 solid; Line 15: margin: 5px 5px 0px 5px; Line 16: padding: 0px; Line 17: height: 200px; Line 18: overflow-y: auto; > on rebase - replace with one statement: "overflow: auto;" Done Line 19: overflow-x: auto; Line 20: } Line 21: Line 22: .textBox { http://gerrit.ovirt.org/#/c/22953/11/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmDiskPopupView.java File frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmDiskPopupView.java: Line 22: @Inject Line 23: public VmDiskPopupView(EventBus eventBus, ApplicationResources resources, ApplicationConstants constants, ApplicationTemplates templates) { Line 24: super(eventBus, resources, new VmDiskPopupWidget(constants, resources, templates, true), "815px", "615px"); //$NON-NLS-1$ //$NON-NLS-2$ Line 25: ViewIdHandler.idHandler.generateAndSetIds(this); Line 26: } This change is not relevant and not correct. Line 27: Line 28: @Override Line 29: public boolean handleEnterKeyDisabled() { Line 30: VmDiskPopupWidget vmDiskPopupWidget = (VmDiskPopupWidget) asWidget().getContent(); -- To view, visit http://gerrit.ovirt.org/22953 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0b9effc07b9a52873f5a4507d882ff76ee091026 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Amador Pahim <apa...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Lior Vernia <lver...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
