Gilad Chaplik has posted comments on this change.

Change subject: frontend: add version name column to templates tab
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/23381/5/frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabTemplateView.java
File 
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabTemplateView.java:

Line 47: 
Line 48:         TextColumnWithTooltip<VmTemplate> versionNameColumn = new 
TextColumnWithTooltip<VmTemplate>() {
Line 49:             @Override
Line 50:             public String getValue(VmTemplate object) {
Line 51:                 return object.getTemplateVersionName();
it would be nice if  "base version" be localized. can you tell it by base_id = 
vmt_id or sth like that?
Line 52:             }
Line 53:         };
Line 54:         getTable().addColumn(versionNameColumn, 
constants.versionTemplate(), "150px"); //$NON-NLS-1$
Line 55: 


-- 
To view, visit http://gerrit.ovirt.org/23381
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iae04ceb5e75ba541f49bbae87e499ee91aacf718
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <aha...@redhat.com>
Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to