Yaniv Dary has posted comments on this change. Change subject: packaging: setup: do not write into /usr/share/ovirt-engine-reports ......................................................................
Patch Set 4: (1 comment) http://gerrit.ovirt.org/#/c/23316/4/packaging/legacy-setup/common_utils.py File packaging/legacy-setup/common_utils.py: Line 647: output, rc = execExternalCmd(cmd, True, "Failed to get package version & release") Line 648: return output.rstrip() Line 649: Line 650: @transactionDisplay("Importing reports") Line 651: def importReports(dir, update=True): what about what sandro said about dir being a reserved name? Line 652: """ Line 653: import the reports Line 654: """ Line 655: logging.debug("importing reports") -- To view, visit http://gerrit.ovirt.org/23316 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8fed79744cf8767c9f6a6b017e2d9e5bc8402182 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yaniv Dary <yd...@redhat.com> Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
