Allon Mureinik has posted comments on this change. Change subject: core, engine, webadmin: Retrieve Capabilities for each Architecture ......................................................................
Patch Set 1: (2 comments) General question - is the configuration the appropriate place for these values? Shouldn't it be under OSInfo? http://gerrit.ovirt.org/#/c/23238/1/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetArchitectureCapabilitiesQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetArchitectureCapabilitiesQuery.java: Line 17: protected void executeQueryCommand() { Line 18: setReturnValue(getMap(getParameters().getArchCapabilitiesVerb())); Line 19: } Line 20: Line 21: private HashMap<ArchitectureType, HashMap<Version, Boolean>> getMap(ArchCapabilitiesVerb archCapabilitiesVerb) { Why declare everything as a Hashmap and not simply a Map? Line 22: Line 23: HashMap<ArchitectureType, HashMap<Version, Boolean>> supportMap = Line 24: new HashMap<ArchitectureType, HashMap<Version, Boolean>>(); Line 25: Line 33: } Line 34: Line 35: supportMap.put(arch, archMap); Line 36: } Line 37: Consider caching this returned Map - it will never change while the system is live, and it might be a pain to re-calculate it each time. Line 38: return supportMap; Line 39: } Line 40: Line 41: /** -- To view, visit http://gerrit.ovirt.org/23238 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied1a97f5bdd42382f0dc832a3fe3abd56d3c89dd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Arik Hadas <aha...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com> Gerrit-Reviewer: Eli Mesika <elimes...@gmail.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Frank Kobzik <fkob...@redhat.com> Gerrit-Reviewer: Gustavo Frederico Temple Pedrosa <gustavo.pedr...@eldorado.org.br> Gerrit-Reviewer: Itamar Heim <ih...@redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernan...@redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com> Gerrit-Reviewer: Leonardo Bianconi <leonardo.bianc...@eldorado.org.br> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Shahar Havivi <shav...@redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjeli...@redhat.com> Gerrit-Reviewer: Vitor de Lima <vitor.l...@eldorado.org.br> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
