Allon Mureinik has posted comments on this change. Change subject: core: Changed storage type checks in commands ......................................................................
Patch Set 3: Code-Review-1 (1 comment) If you're removing DAO calls, please also remove the underlying stored procedures. http://gerrit.ovirt.org/#/c/23295/3//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-01-16 15:59:25 +0200 Line 4: Commit: Tal Nisan <tni...@redhat.com> Line 5: CommitDate: 2014-01-16 15:59:25 +0200 Line 6: Line 7: core: Changed storage type checks in commands This is not what the patch does :-) Line 8: Line 9: As a part of the effort to remove the type of storage pool the unused Line 10: methods concerning pool types were removed in StorageDomainStaticDao and Line 11: their tests -- To view, visit http://gerrit.ovirt.org/23295 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab29347dd82ea47bf6e0d1d5542db9d6d52c0b08 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Ayal Baron <aba...@redhat.com> Gerrit-Reviewer: Daniel Erez <de...@redhat.com> Gerrit-Reviewer: Federico Simoncelli <fsimo...@redhat.com> Gerrit-Reviewer: Liron Ar <lara...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Sergey Gotliv <sgot...@redhat.com> Gerrit-Reviewer: Tal Nisan <tni...@redhat.com> Gerrit-Reviewer: Vered Volansky <vvola...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
