Kanagaraj M has posted comments on this change. Change subject: engine: BLL command to refresh volume details ......................................................................
Patch Set 5: (1 comment) http://gerrit.ovirt.org/#/c/23262/5/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RefreshGlusterVolumeDetailsCommand.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/RefreshGlusterVolumeDetailsCommand.java: Line 12: * BLL command to refresh gluster volume details Line 13: */ Line 14: @NonTransactiveCommandAttribute Line 15: @LockIdNameAttribute(isWait = true) Line 16: public class RefreshGlusterVolumeDetailsCommand extends GlusterVolumeCommandBase<GlusterVolumeParameters> { > Remove the Lock attribute. GlusterSyncJob.refreshVolumeDetails() doesn't acquire any lock so lock should be acquired here Line 17: Line 18: public RefreshGlusterVolumeDetailsCommand(GlusterVolumeParameters params) { Line 19: super(params); Line 20: } -- To view, visit http://gerrit.ovirt.org/23262 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie06c6a45e00f35df45e130cdceb592e81b67998e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
