Kanagaraj M has posted comments on this change. Change subject: gluster: update volume capacity info in sync job ......................................................................
Patch Set 9: Code-Review+1 (1 comment) http://gerrit.ovirt.org/#/c/23011/9/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterSyncJob.java: Line 802: } Line 803: } Line 804: } Line 805: Line 806: public void refreshVolumeDetails(VDS upServer, GlusterVolumeEntity volume) { > If this can be called from outside(bll), lock should be acquired by the cal Please ignore this comment Line 807: List<GlusterBrickEntity> bricksToUpdate = new ArrayList<GlusterBrickEntity>(); Line 808: List<GlusterBrickEntity> brickPropertiesToUpdate = new ArrayList<GlusterBrickEntity>(); Line 809: List<GlusterBrickEntity> brickPropertiesToAdd = new ArrayList<GlusterBrickEntity>(); Line 810: -- To view, visit http://gerrit.ovirt.org/23011 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifd187eb59ab83c426db7e9ba48a04ae7e0bef0b9 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: anmolbabu <anb...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
