Eli Mesika has submitted this change and it was merged. Change subject: core: Cleanup DiskImageDAO and its test ......................................................................
core: Cleanup DiskImageDAO and its test General java cleanup: 1. make "instance" row mapper final 2. narrow scope of private helper methods 3. Use existing constants in FixturesTool 4. Adding missing @Override annotation 5. Remove unused, unimplemented method 6. Added missing @Test annotation Change-Id: Ia182dfcd45f5923501dffa57b7f98f7d4a72ab1c Signed-off-by: Allon Mureinik <amure...@redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAOWrapperImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDAOTest.java 3 files changed, 19 insertions(+), 24 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Allon Mureinik: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/4205 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia182dfcd45f5923501dffa57b7f98f7d4a72ab1c Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipc...@redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkole...@redhat.com> _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
