Kanagaraj M has posted comments on this change. Change subject: engine: Sync gluster bricks - use server uuid ......................................................................
Patch Set 1: (2 comments) http://gerrit.ovirt.org/#/c/23322/1/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumesListReturnForXmlRpc.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterVolumesListReturnForXmlRpc.java: Line 36: private static final String REPLICA_COUNT = "replicaCount"; Line 37: private static final String STRIPE_COUNT = "stripeCount"; Line 38: private static final String BRICKS_INFO = "bricksInfo"; //contains brick name and server uuid Line 39: private static final String NAME = "name"; Line 40: private static final String HOST_UUID = "hostUuid"; HOST_UUID not being used Line 41: Line 42: private Guid clusterId; Line 43: private final Map<Guid, GlusterVolumeEntity> volumes = new HashMap<Guid, GlusterVolumeEntity>(); Line 44: private static Log log = LogFactory.getLog(GlusterVolumesListReturnForXmlRpc.class); Line 168: String brickDir = brickParts[1]; Line 169: Line 170: VdsStatic server = dbUtils.getServer(clusterId, hostnameOrIp); Line 171: if (server == null) { Line 172: log.errorFormat("Could not add brick {0} to volume {1} - server {2} not found in cluster {3}", brickInfo, volumeId, hostnameOrIp, clusterId); this could be WARN Line 173: return null; Line 174: } Line 175: Line 176: return getBrickEntity(clusterId, volumeId, brickOrder, server, brickDir); -- To view, visit http://gerrit.ovirt.org/23322 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2076e77b5415ead7faf6641ce31588333222e70f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayi...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
