Yedidyah Bar David has posted comments on this change.

Change subject: packaging: osinfo: move sysprep defaults out of /etc
......................................................................


Patch Set 5:

(1 comment)

http://gerrit.ovirt.org/#/c/22384/5/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/legacy/osinfo.py
File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/legacy/osinfo.py:

Line 45:     @plugin.event(
Line 46:         stage=plugin.Stages.STAGE_MISC,
Line 47:         condition=lambda self: self.environment[
Line 48:             osetupcons.CoreEnv.ACTION
Line 49:         ] == osetupcons.Const.ACTION_UPGRADE,
You removed ACTION_UPGRADE. What is it rebased on?
Line 50:         after=[
Line 51:             osetupcons.Stages.DB_CONNECTION_AVAILABLE,
Line 52:         ],
Line 53:     )


-- 
To view, visit http://gerrit.ovirt.org/22384
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I26a853c12ca091f340d6ebed2c10726462ec576a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com>
Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com>
Gerrit-Reviewer: Francesco Romani <from...@redhat.com>
Gerrit-Reviewer: Itamar Heim <ih...@redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofren...@redhat.com>
Gerrit-Reviewer: Roy Golan <rgo...@redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches

Reply via email to