Sandro Bonazzola has posted comments on this change. Change subject: packaging: verify sysctl.shmmax after modification ......................................................................
Patch Set 3: (1 comment) http://gerrit.ovirt.org/#/c/23284/3/packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/sysctl.py File packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/system/sysctl.py: Line 148: Line 149: # Verify shmmax is set correctly Line 150: shmmax = self._get_shmmax() Line 151: Line 152: if shmmax >= self.environment[osetupcons.SystemEnv.SHMMAX]: shouldn't this be <= ? Line 153: self.logger.debug( Line 154: 'sysctl kernel.shmmax is %s lower than %s' % ( Line 155: shmmax, Line 156: self.environment[osetupcons.SystemEnv.SHMMAX], -- To view, visit http://gerrit.ovirt.org/23284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If2e1eafad9dacfa4d784526cdd0118c45cc47ccb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschr...@redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbona...@redhat.com> Gerrit-Reviewer: Yedidyah Bar David <d...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
