Francesco Romani has posted comments on this change. Change subject: agent: Implement basics for API Versioning ......................................................................
Patch Set 8: (2 comments) http://gerrit.ovirt.org/#/c/16995/8/ovirt-guest-agent/OVirtAgentLogic.py File ovirt-guest-agent/OVirtAgentLogic.py: Line 37: Line 38: Line 39: class DataRetriverBase: Line 40: def __init__(self): Line 41: self.apiVersion = 0 Maybe a constant here? Line 42: self.memStats = { Line 43: 'mem_total': 0, Line 44: 'mem_free': 0, Line 45: 'mem_unused': 0, Line 247: elif command == 'refresh': Line 248: if not 'apiVersion' in args and self.dr.getAPIVersion() > 0: Line 249: logging.info('API versioning not supported by VDSM. Disabling ' Line 250: 'versioning support.') Line 251: self.dr.setAPIVersion(0) And a constant here too Line 252: self.sendUserInfo(True) Line 253: self.sendAppList() Line 254: self.sendInfo() Line 255: self.sendDisksUsages() -- To view, visit http://gerrit.ovirt.org/16995 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I754d52009538914dd0143894b24ad48fbf13cb38 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: Francesco Romani <from...@redhat.com> Gerrit-Reviewer: Martin Sivák <msi...@redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skriva...@redhat.com> Gerrit-Reviewer: Roy Golan <rgo...@redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeen...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
