Ramesh N has posted comments on this change. Change subject: restapi: WIP-Introduced statistics for glustervolumes ......................................................................
Patch Set 2: (2 comments) http://gerrit.ovirt.org/#/c/22579/2/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeSizeInfoQuery.java File backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeSizeInfoQuery.java: Line 44: // info.setFreeSize(1024L); Line 45: // info.setUsedSize(1024L); Line 46: // info.setTotalSize(2048L); Line 47: // lst.add(info); Line 48: // getQueryReturnValue().setReturnValue(lst); > Remove the above test lines Done Line 49: } Line 50: Line 51: private List<GlusterVolumeSizeInfo> fetchVolumeCapacityDetails() { Line 52: final List<GlusterVolumeSizeInfo> sizeInfos = new ArrayList<>(); http://gerrit.ovirt.org/#/c/22579/2/backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumeResource.java File backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumeResource.java: Line 143: public StatisticsResource getStatisticsResource() { Line 144: EntityIdResolver<Guid> resolver = Line 145: new QueryIdResolver<Guid>(VdcQueryType.GetGlusterVolumeById, IdQueryParameters.class) { Line 146: Line 147: @Override > Do you really need to override lookupEntity? I think we no longer need a query to backend(VDSM). We can just read the volume entity and it will have the capacity information by default. Line 148: public GlusterVolumeEntity lookupEntity(Guid id) throws BackendFailureException { Line 149: GlusterVolumeEntity volumeEntity = getEntity(GlusterVolumeEntity.class, Line 150: VdcQueryType.GetGlusterVolumeById, Line 151: new IdQueryParameters(id), -- To view, visit http://gerrit.ovirt.org/22579 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6b17170f403c6ac320829b23b8e2d03b537b8ff2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shubhendu Tripathi <shtri...@redhat.com> Gerrit-Reviewer: Ramesh N <rnach...@redhat.com> Gerrit-Reviewer: Sahina Bose <sab...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
