Liran Zelkha has posted comments on this change. Change subject: engine: Json-rpc integration ......................................................................
Patch Set 20: Code-Review+1 (3 comments) http://gerrit.ovirt.org/#/c/20926/20/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcUtils.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcUtils.java: Line 15: Line 16: public class JsonRpcUtils { Line 17: private static Log log = LogFactory.getLog(JsonRpcUtils.class); Line 18: Line 19: public static final int JSONRPC_PORT = 4044; Shouldn't the port be a configuration property? Line 20: Line 21: public static JsonRpcClient createClient(String hostName, int port, int connectionTimeOut, Line 22: int clientTimeOut, int connectionRetry, boolean isSecure) { Line 23: ManagerProvider provider = null; http://gerrit.ovirt.org/#/c/20926/20/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java File backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/jsonrpc/JsonRpcVdsServer.java: Line 253: } Line 254: Line 255: @Override Line 256: public OneVmReturnForXmlRpc changeDisk(String vmId, String imageLocation) { Line 257: // DriveSpec should be used instead of imageLocation So TODO: ? Line 258: JsonRpcRequest request = Line 259: new RequestBuilder("VM.changeCD").withParameter("vmID", vmId) Line 260: .withParameter("driveSpec", imageLocation) Line 261: .build(); Line 265: } Line 266: Line 267: @Override Line 268: public OneVmReturnForXmlRpc changeFloppy(String vmId, String imageLocation) { Line 269: // DriveSpec should be used instead of imageLocation So TODO: ? Line 270: JsonRpcRequest request = new RequestBuilder("VM.changeFloppy").withParameter("vmID", vmId) Line 271: .withParameter("driveSpec", imageLocation).build(); Line 272: Map<String, Object> response = Line 273: new FutureMap(this.client, request).withResponseKey("status"); -- To view, visit http://gerrit.ovirt.org/20926 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I66ef0c98f07de6c447a5fffc42c9dbc94580df46 Gerrit-PatchSet: 20 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Alon Bar-Lev <alo...@redhat.com> Gerrit-Reviewer: Barak Azulay <bazu...@redhat.com> Gerrit-Reviewer: Eli Mesika <emes...@redhat.com> Gerrit-Reviewer: Liran Zelkha <lzel...@redhat.com> Gerrit-Reviewer: Martin Peřina <mper...@redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczew...@gmail.com> Gerrit-Reviewer: Saggi Mizrahi <smizr...@redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzasl...@redhat.com> Gerrit-Reviewer: mooli tayer <mta...@redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes _______________________________________________ Engine-patches mailing list Engine-patches@ovirt.org http://lists.ovirt.org/mailman/listinfo/engine-patches
